[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Suppress locking initialisation failure messages when --ignorelockingfailure is used



On 02/08/2010 02:17 PM, Peter Rajnoha wrote:
> We should not show error messages about locking initialisation failures when it is expected
> and --ignorelockingfailure option is used (rhbz #561938).

> 
> diff --git a/lib/locking/locking.c b/lib/locking/locking.c
> index 54e5e25..db70433 100644
> --- a/lib/locking/locking.c
> +++ b/lib/locking/locking.c
> @@ -237,7 +237,8 @@ int init_locking(int type, struct cmd_context *cmd)
>  				 _blocking_supported ? "" : "Non-blocking ");
>  
>  		if (!init_file_locking(&_locking, cmd)) {
> -			log_error("File-based locking initialisation failed.");
> +			if (!ignorelockingfailure())
> +				log_error("File-based locking initialisation failed.");

I do not like this patch at all.

"Ignore locking failure" does not mean "Do not print error when locking failed" IMHO.

I thought that dracut use rw root. So something changed again and remounts it to read-only again?

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]