[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Add mirror log to dependency tree using its UUID.



On 02/12/2010 09:42 AM, Petr Rockai wrote:
> If I was a little more careful to check the patch, this could have been
> easy... You have moved the _mlog from _add_lv_to_dtree to
> _create_partial_dtree -- but this is not correct! The following patch
> works:

:-)

> @@ -823,7 +823,8 @@ static int _add_lv_to_dtree(struct dev_m
>  	if (!_add_dev_to_dtree(dm, dtree, lv, "cow"))
>  		return_0;
>  
> -	if (!_add_dev_to_dtree(dm, dtree, lv, "_mlog"))
> +	if ((lv->status & MIRRORED) && first_seg(lv)->log_lv &&
> +	    !_add_dev_to_dtree(dm, dtree, first_seg(lv)->log_lv, NULL))
>  		return_0;

yes, this seem to be correct, ack

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]