[lvm-devel] [PATCH] Do not print "-1" as locking type if locking fails.
Milan Broz
mbroz at redhat.com
Thu Jan 21 17:38:13 UTC 2010
On 01/21/2010 06:23 PM, Dave Wysochanski wrote:
>> @@ -249,8 +251,10 @@ int init_locking(int type, struct cmd_context *cmd)
>> }
>> if (!find_config_tree_int(cmd, "locking/fallback_to_clustered_locking",
>> find_config_tree_int(cmd, "global/fallback_to_clustered_locking",
>> - DEFAULT_FALLBACK_TO_CLUSTERED_LOCKING)))
>> + DEFAULT_FALLBACK_TO_CLUSTERED_LOCKING))) {
>> + log_error("External locking initialisation failed.");
>> break;
>> + }
>> #endif
>
> This looks strange and inconsistent with the rest of the code.
> IMO the message be directly under the above code when
> init_external_locking() fails, as the others are.
yes. because there is quiet fallback to internal cluster locking, I think it should not print
error when fallback to internal locking succeeded.
(I think there are many RHEL4 configuration set to locking type 2 still)
Milan
More information about the lvm-devel
mailing list