[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2 ./WHATS_NEW doc/example.conf.in lib/comma ...

On Fri, Jul 02, 2010 at 11:03:49AM +0200, Peter Rockai wrote:
> Have you forgotten to cvs add filter-suspended.[hc]?

Rather - forgot to remove the #include line after deciding it was
pointless bloat to make it into a separate filter.

> hand, I am not convinced that it helps in Mikuláš's case (RHBZ
> 598135). 

I already fixed that bug, which was a case where the cache became
internally inconsistent.

> In his case, the device would still end up in valid_devices in
> the persistent cache and as long as it was just a regular (non-dm) block
> device or partition, the appearance of MD metadata could go unnoticed.

That's a different case from the one he reported and not a problem
(apart from the races I already mentioned): before LVM takes a
non-dm block device and turns it into a PV it checks for MD metadata
as part of the 'pvcreate' functionality.
Neil will be adding a reciprocal check into mdadm, which is the only
way to stop the opposite problem of mdadm clobbering a PV.
But without system-wide locking and co-operation between all the admin
tools there are always going to be races possible if admins perform
conflicting commands.  All of the caching code is about choosing a
delicate compromise.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]