[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] clvmd should create its own pid file



On 07/08/2010 04:59 PM, Alasdair G Kergon wrote:
Does this work OK with clvmd -S?

Yes. It appears to be working fine.

Should we have FD_CLOEXEC ?

(See pidfile.c in multipathd.)

I don't have any special preference. I noticed that the pid file implementations in other daemons (within lvm2) don't use it nor unlink the pid file on exit.

Also, let's make it library code rather than copying it from cmirrord.

Works for me.

I am going to make it a lib call and cleanup both cmirrord/dmeventd/clvmd.

Do you have anything against atexit() handler? That's what we use in cluster daemons to unlink the pid files.

Cheers
Fabio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]