[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] pid files cleanup



On Fri, Jul 09, 2010 at 11:04:04AM +0200, Fabio M. Di Nitto wrote:
> +	/* Create pidfile */
> +	if (create_lockfile(CLVMD_PIDFILE) < 0) {

For functions in lvm, our convention is to return 1 on success or 0 on failure.

> +++ b/daemons/cmirrord/Makefile.in

> +LVMLIBS = $(LVMINTERNAL_LIBS)

Hmmm.

We still have already:
  cmirrord: $(OBJECTS) $(top_builddir)/lib/liblvm-internal.a

- Does the definition above mean this bit can come out?

> +++ b/lib/misc/lvm-file.c
> +	return 0;

return 1;

> +	return -errno;

return 0;

(This function already handled/reported errno appropriately.)

Looks good - ack.

Alasdair



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]