[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Clean up cluster lock mode and flags definition.



On Fri, June 4, 2010 12:11 pm, Milan Broz wrote:
> Code is mixing up internal DLM and LVM definitions of lock
> modes and flags.
>
> OpenAIS and singlenode locking do not depend on DLM but
> code currently cannot be compiled without libdlm.h!
>
> LCK_* flags is LVM abstraction, used through all the code.
> Only low-level backend (clvmd-cmac etc) should use DLM definitions,
> also this code should do all needed conversions.
>
> Because there are two DLM flags used in generic code
> (NOQUEUE, CONVERT) we define it similar way like lock modes.
> (So all needed binary-compatible flags are on one place in locking.h)

Thanks!

When I send the patch to fix this issue:

https://www.redhat.com/archives/lvm-devel/2010-May/msg00180.html

I change all references to use <linux/dlm.h> avoiding <libdlm.h>.
I didnĀ“t know we have the same definitions (with internal names) on
locking.h.

With your fix I can continue compiling clvmd+openais without the
need of libdlm and, now, without the need of patching the sources.

Thanks again!

Piter Punk


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]