[lvm-devel] [PATCH 19/38] Refactor vg_commit() to add _vg_commit_mdas().
Dave Wysochanski
dwysocha at redhat.com
Sat Jun 26 02:52:50 UTC 2010
Factor out calling mda->ops->vg_commit() for each mda.
No functional change.
Signed-off-by: Dave Wysochanski <dwysocha at redhat.com>
---
lib/metadata/metadata.c | 26 +++++++++++++++++---------
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 5ec78f0..398f149 100644
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -2424,18 +2424,11 @@ int vg_write(struct volume_group *vg)
return 1;
}
-/* Commit pending changes */
-int vg_commit(struct volume_group *vg)
+static int _vg_commit_mdas(struct volume_group *vg)
{
struct metadata_area *mda;
- int cache_updated = 0;
int failed = 0;
-
- if (!vgname_is_locked(vg->name)) {
- log_error(INTERNAL_ERROR "Attempt to write new VG metadata "
- "without locking %s", vg->name);
- return cache_updated;
- }
+ int cache_updated = 0;
/* Commit to each copy of the metadata area */
dm_list_iterate_items(mda, &vg->fid->metadata_areas) {
@@ -2451,6 +2444,21 @@ int vg_commit(struct volume_group *vg)
cache_updated = 1;
}
}
+ return cache_updated;
+}
+
+/* Commit pending changes */
+int vg_commit(struct volume_group *vg)
+{
+ int cache_updated = 0;
+
+ if (!vgname_is_locked(vg->name)) {
+ log_error(INTERNAL_ERROR "Attempt to write new VG metadata "
+ "without locking %s", vg->name);
+ return cache_updated;
+ }
+
+ cache_updated = _vg_commit_mdas(vg);
if (cache_updated) {
/* Instruct remote nodes to upgrade cached metadata. */
--
1.6.0.6
More information about the lvm-devel
mailing list