[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] restore the "removemissing" behaviour of lvconvert --repair --use-policies



Alasdair G Kergon <agk redhat com> writes:

> On Wed, Jun 30, 2010 at 10:43:53PM +0200, Peter Rockai wrote:
>> -	struct dm_list *failed_pvs = NULL;
>
>> -	if (!(failed_pvs = _failed_pv_list(lv->vg)))
>> +	if (!(lp->failed_pvs = _failed_pv_list(lv->vg)))
>
> How does the patch work?

Ah, this is not mentioned in the patch since it was not changed. The
missing piece of the puzzle is this:

   1567                 if (arg_count(cmd, repair_ARG) && arg_count(cmd, use_policies_ARG))
   1568                         _remove_missing_empty_pv(lv->vg, lp->failed_pvs);
                                                                 ^^^^

Yours,
   Petr.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]