[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Fix segfault when destroying in-use filters in pvs -a.



Milan,

On 03/11/10 14:57, Takahiro Yasui wrote:
> On 03/10/10 16:43, Milan Broz wrote:
>> Because pvs -a iterate throught the whole device cache
>> we should not refresh filters inside iteration.
>>
>> Fix it by introducing simple reference counter and test
>> it in refresh_filters() call.
>>
>> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=571963

This patch worked fine in my test case, but I have one question about
your patch. I assume that you added refresh_filters() because it was
necessary, but this patch prevents filter from being refreshed if it
is in use.

Don't we need to refresh the filter when in_use flag is decremented
and becomes 0 after or in dev_iter_destroy()?

Thanks,
Taka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]