[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Remove the double open with same mode



On 13.3.2010 05:18, Alasdair G Kergon wrote:
> On Fri, Mar 12, 2010 at 04:17:56PM -0800, Malahal Naineni wrote:
>>  	if ((open("/dev/null", O_RDONLY) < 0) ||
>> -	    (open("/dev/null", O_WRONLY) < 0) ||
>>  	    (open("/dev/null", O_WRONLY) < 0))
>>  		exit(EXIT_DESC_OPEN_FAILURE);
> 
> stdin, stdout, stderr
> 
> Alasdair
> 

IMHO it's probably worth to add comment to code, so there will not be similar
'optimizations' proposed in the future.

Zdenek.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]