[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Fix segfault when destroying in-use filters in pvs -a.



On 03/12/2010 05:56 PM, Takahiro Yasui wrote:
>>> Fix it by introducing simple reference counter and test
>>> it in refresh_filters() call.
>>>
>>> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=571963
> 
> This patch worked fine in my test case, but I have one question about
> your patch. I assume that you added refresh_filters() because it was
> necessary, but this patch prevents filter from being refreshed if it
> is in use.
> 
> Don't we need to refresh the filter when in_use flag is decremented
> and becomes 0 after or in dev_iter_destroy()?

well, the patch is workaround. It should be correct fot _this_
one place.

The full refresh (including filter refresh) should be done in
scan_vgs_for_pvs() (before the iteration loop) so later refresh
should not be needed.
(So we should fix code to not full scan here in the first place...)

I see several more problems with repeated full refresh now,
so maybe some more intrusive solution will be needed.

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]