[lvm-devel] [PATCH] Remove the double open with same mode
Bryn M. Reeves
bmr at redhat.com
Mon Mar 15 15:37:28 UTC 2010
On Mon, 2010-03-15 at 09:59 +0100, Zdenek Kabelac wrote:
> On 13.3.2010 05:18, Alasdair G Kergon wrote:
> > On Fri, Mar 12, 2010 at 04:17:56PM -0800, Malahal Naineni wrote:
> >> if ((open("/dev/null", O_RDONLY) < 0) ||
> >> - (open("/dev/null", O_WRONLY) < 0) ||
> >> (open("/dev/null", O_WRONLY) < 0))
> >> exit(EXIT_DESC_OPEN_FAILURE);
> >
> > stdin, stdout, stderr
> >
> > Alasdair
> >
>
> IMHO it's probably worth to add comment to code, so there will not be similar
> 'optimizations' proposed in the future.
Or dup(2) stdout onto stderr - iirc this is how the code in init/main.c
in the kernel is organised and it does make things a little bit more
obvious / readable.
Regards,
Bryn.
More information about the lvm-devel
mailing list