[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Remove vgname check from _find_vg_rlocn and just return the rlocn slot.



On Fri, Mar 26, 2010 at 01:38:46PM -0400, Dave Wysochanski wrote:
> Unclear what the purpose of this check was/is.  Removing it allows for easier
> refactoring, fixes at least one bug, and at least breaks no tests.  If it
> covers and important case, we should add a comment and/or testcase.
 
The on-disk layout supports multiple mdas for different VGs stored on the same
disk.  But at the moment we only use one.
[Create a test case: PV with 2 mdas, and different vgname in each...current
code should ignore the 2nd one, maybe overwriting it with copy of first, I'm
not sure.]

> -	/* FIXME Loop through rlocns two-at-a-time.  List null-terminated. */

> -	/* FIXME Ignore if checksum incorrect!!! */

FIXME removed, so does the patch now validate the checksum?

I think the vgname validation is still needed on almost all occasions.
Only the 'tell me which VG is in this mda' case doesn't want it.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]