[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 05/23] Replicator: suspend/deactivate replicator



On Wed, Apr 28, 2010 at 02:27:24PM +0200, Zdenek Kabelac wrote:
> Introducing dm_tree_set_suspend_priority() for suspending replicator
> control target before deactivation of replicator-dev target.
 
Not keen on this one - need a bit more information as to why we need this, and
then why the existing function dm_tree_suspend_children() - perhaps extended with an
'inverted' parameter - is insufficient.

> +static int _suspend_parent(struct dm_tree_node *dnode, const char *uuid_prefix,

> +		if (!dlink->node->suspend_priority)
> +			continue;

Why is this hard-coded only to cope with one value of suspend_priority?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]