[lvm-devel] [PATCH] Use dynamic allocation for buffer when reporting tags

Milan Broz mbroz at redhat.com
Mon Nov 1 13:16:25 UTC 2010


On 11/01/2010 02:08 PM, Peter Rajnoha wrote:
> OK, here's updated version (based on quick hints from Milan).

ack + tested, works for my test script


> @@ -902,11 +919,13 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field)
>  
>  		if (!dm_pool_grow_object(rh->mem, rh->output_field_name_prefix, 0)) {
>  			log_error("dm_report: Unable to extend output line");
> +			free(field_id);
>  			return 0;

just mention in changelog that this is additional memleak fix.

Milan




More information about the lvm-devel mailing list