[lvm-devel] [PATCH 16/29] Test uuid for NULL
Zdenek Kabelac
zkabelac at redhat.com
Thu Nov 25 10:55:20 UTC 2010
This one again makes static analysis easier.
Though in this case when uuid is NULL len is also 0 so no bytes are
copied from the src address so no dereference happens - the function
memcpy itself is declared as the function which doesn't take
NULL as either src or dst parameter - let's be complaint.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
tools/dmsetup.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/dmsetup.c b/tools/dmsetup.c
index 241fa74..1a56d24 100644
--- a/tools/dmsetup.c
+++ b/tools/dmsetup.c
@@ -343,7 +343,9 @@ static char *_extract_uuid_prefix(const char *uuid, const int separator)
return NULL;
}
- memcpy(uuid_prefix, uuid, len);
+ if (uuid)
+ memcpy(uuid_prefix, uuid, len);
+
uuid_prefix[len] = '\0';
return uuid_prefix;
--
1.7.3.2
More information about the lvm-devel
mailing list