[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/2] Update errno codes for vg_read() and lvm2app lvm_vg_open().



Hi,

I am not checking this in yet, I would like to discuss the value choices
first a bit. Presumably, once we set them, we are sort of stuck with the
choices, so we should be careful.

Dave Wysochanski <wysochanski pobox com> writes:

> Update errno codes for vg_read error paths:
> - EINVAL: invalid vg_name
> - ENOLCK: lock_vol fails
EBUSY? (But really, this probably depends on *why* _lock_vol
failed... maybe we need to drill down here?)

> - ENODEV: VG 'vgname' does not exist
> - EPROTOTYPE: VG is clustered but locking not clustered
What about just EPROTO? Or ENOLCK?

> - EROFS: VG is read-only
If we want to re-use existing errnos, I would go with EACCESS or EPERM
here. EROFS *sounds* similar, but is IMHO a semantical misfit.

> - EUCLEAN: VG is inconsistent
This one is tricky. I would almost not assign an errno here at least for
now.

Yours,
   Petr.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]