[lvm-devel] LVM2/daemons/clvmd lvm-functions.c

[Alasdair G Kergon]

On Mon, Nov 29, 2010 at 11:05:15AM -0000, zkabelac at sourceware.org wrote:
> 	Remove printing of LCK_CACHE
 	
But straightforward to fix so it still gets printed (somewhere)?

> 	If the LCK_CLUSTER should be printed here - lot of code need
> 	to be reworked - so adding FIXME comment.
 
With code like:
  (lock_flags & LCK_CLUSTER_VG)
LCK_CLUSTER_VG (I presume you meant) should it be handled by decode_flags?

> + * FIXME: 8bit value passed here -
> + *        so only LCK_XXX defines < 0x100 can be decoded

(Not really the thing to fix.)

Alasdair