[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 10/29] Add some backtrace - Attention please



On Thu, Nov 25, 2010 at 11:55:14AM +0100, Zdenek Kabelac wrote:
> -		dm_task_set_name(dmt, dirent->d_name);
> -		dm_task_run(dmt);
> +		if (!dm_task_set_name(dmt, dirent->d_name)) {
> +			stack;
> +			continue; /* try next name */
> +		}
> +		if (!dm_task_run(dmt))
> +                        stack;  /* keep going */

Yes, best endeavours makes sense in this (repair) function.
but add some 'r = 0' to return 0 not 1 if any of them failed.

Ack.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]