[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 29/29] Check for NULL pointer



On Fri, Nov 26, 2010 at 12:02:33AM +0100, Zdenek Kabelac wrote:
> +	default:
> +		log_error(INTERNAL_ERROR "Unknown report type.");
> +		return ECMD_FAILED;

It's an enum where we cover every value.  An assertion is frankly
pointless.

I could equally perform my own 'static analysis' and deduce that the
default case there is redundant and delete it:)

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]