[lvm-devel] [PATCH 1/6] Fix compiler warning about strict-aliasing break

[Petr Rockai]

Zdenek Kabelac <zkabelac at redhat.com> writes:

> This patch not really tested - and just show a possible solution
> for strict-alliasing error.
>
> So patch is just a proposal of one of many solution.

The patch looks OK, the code is actually cleaner that way. You can also
drop PART_MAGIC_OFFSET which is no longer used (I have checked that it
is indeed PART_OFFSET + 4*sizeof(struct partition)).

I believe the code is equivalent to what was there before. Nevertheless,
a regression test that would cover this area would be more than welcome.

Reviewed-By: Petr Rockai <prockai at redhat.com>

Yours,
  Petr.