[lvm-devel] [PATCH] lvconvert: provide useful error when snapshot-merge target missing
Milan Broz
mbroz at redhat.com
Wed Oct 13 19:06:53 UTC 2010
On 10/13/2010 08:53 PM, Mike Snitzer wrote:
> Convey need for snapshot-merge target in lvconvert error message and man
> page.
> --- a/lib/metadata/segtype.h
> +++ b/lib/metadata/segtype.h
> @@ -66,6 +66,7 @@ struct segment_type {
>
> struct segtype_handler {
> const char *(*name) (const struct lv_segment * seg);
> + const char *(*target_name) (const struct lv_segment * seg);
> void (*display) (const struct lv_segment * seg);
> int (*text_export) (const struct lv_segment * seg,
> struct formatter * f);
I think this will break shared (external) segment module ABI.
Nobody uses that but worth to mention it.
(See e.g. lib/mirror and --with-mirrors=shared)
Otherwise ack.
Milan
More information about the lvm-devel
mailing list