[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 13/30] Eliminate uninitialized_var



Dne 25.10.2010 12:18, ejt redhat com napsal(a):
> At Mon, 25 Oct 2010 10:24:20 +0200,
> Zdenek Kabelac wrote:
>>
>> Use some default value instead of a random number for unknown
>> minor_version.
>>
>> Signed-off-by: Zdenek Kabelac <zkabelac redhat com>
> 
> Nack.  What if your default |sb_offset| is wrong?

Still better something defined - then completely random value.

But this patch is rather about make compiler analyzer quiet -
maybe  default: assert() for 'generic' version ?

>From the source code - we are actually using only  MD_MINOR_V0,
as is: minor = MD_MINOR_VERSION_MIN (== MD_MINOR_V0)

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]