[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 16/30] Fix void* pointer arithmetic



At Mon, 25 Oct 2010 13:17:05 +0200,
Zdenek Kabelac wrote:
> 
> Dne 25.10.2010 12:20, ejt redhat com napsal(a):
> > At Mon, 25 Oct 2010 10:24:23 +0200,
> > Zdenek Kabelac wrote:
> >>
> >>
> >> Signed-off-by: Zdenek Kabelac <zkabelac redhat com>
> > 
> > Nack.  No explanation.  eg, Are we deprecating the void pointer arithmetic gcc extension?
> 
> void* arithmetic is IMHO bad practice and we should avoid it's usage.
> char* clearly defines 1byte - I'd prefer to use standard C whenever we can.
> (And gcc can show this as warning - so why not fixing it)

Ack


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]