[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2/daemons/clvmd clvmd.c



On Tue, Oct 26, 2010 at 09:57:04AM -0000, zkabelac sourceware org wrote:
> +#ifdef __clang__
>  		__builtin_unreachable();
> +#endif

Please do not scatter #ifdefs like that through the code.
If the standard /* NOTREACHED */ really doesn't work, then hide the
ifdef in a header file and use a #define to make it available precisely
where the compiler supports it, defining it to something empty
elsewhere.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]