[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 04/19] Call id_format_and_copy from _uuid_disp.



Dne 15.9.2010 17:35, Dave Wysochanski napsal(a):
> 
> Signed-off-by: Dave Wysochanski <dwysocha redhat com>
> ---
>  lib/report/report.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/report/report.c b/lib/report/report.c
> index b7612a1..940ee25 100644
> --- a/lib/report/report.c
> +++ b/lib/report/report.c
> @@ -677,13 +677,8 @@ static int _uuid_disp(struct dm_report *rh __attribute__((unused)), struct dm_po
>  {
>  	char *repstr = NULL;
>  
> -	if (!(repstr = dm_pool_alloc(mem, 40))) {
> -		log_error("dm_pool_alloc failed");
> +	if (!(repstr = id_format_and_copy(mem, (struct id *)data)))
>  		return 0;
> -	}
> -
> -	if (!id_write_format((const struct id *) data, repstr, 40))
> -		return_0;

return_0 should be used after NULL detection from id_format_and_copy()

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]