[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 11/20] Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv.



Dne 22.9.2010 23:06, Dave Wysochanski napsal(a):
> Will need similar macros for VG, PV and LV, so define a generic one, and just
> pass in the struct name and variable name for the specific macro.
> 
> Signed-off-by: Dave Wysochanski <dwysocha redhat com>
> ---
>  lib/report/properties.c |   25 +++++++++++++++++++++++--
>  1 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/report/properties.c b/lib/report/properties.c
> index 9e3cad3..b39a979 100644
> --- a/lib/report/properties.c
> +++ b/lib/report/properties.c
> @@ -20,14 +20,35 @@
>  #include "lvm-types.h"
>  #include "metadata.h"
>  
> -#define GET_NUM_PROPERTY_FN(NAME, VALUE) \
> +#define GET_NUM_PROPERTY_FN(NAME, VALUE, STRUCT, VAR)			\
>  static int _ ## NAME ## _get (void *obj, struct lvm_property_type *prop) \
>  { \
> -	struct volume_group *vg = (struct volume_group *)obj; \
> +	struct STRUCT *VAR = (struct STRUCT *)obj; \


struct STRUCT *VAR


looks weird... isn't there something better?

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]