[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] LVM2 ./WHATS_NEW daemons/clvmd/clvmd-singlenode.c



CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac sourceware org	2011-08-04 12:13:51

Modified files:
	.              : WHATS_NEW 
	daemons/clvmd  : clvmd-singlenode.c 

Log message:
	Add test for fcntl error in singlenode client code.
	
	Static analyzer noticed this check could be handy.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2048&r2=1.2049
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-singlenode.c.diff?cvsroot=lvm2&r1=1.10&r2=1.11

--- LVM2/WHATS_NEW	2011/08/04 10:14:42	1.2048
+++ LVM2/WHATS_NEW	2011/08/04 12:13:50	1.2049
@@ -1,5 +1,6 @@
 Version 2.02.87 - 
 ===============================
+  Add test for fcntl error in singlenode client code.
   Remove --force option from lvrename manpage.
   Add missing new line in lvrename help text.
   Add basic support for RAID 1/4/5/6 (i.e. create, remove, display)
--- LVM2/daemons/clvmd/clvmd-singlenode.c	2011/03/24 10:45:00	1.10
+++ LVM2/daemons/clvmd/clvmd-singlenode.c	2011/08/04 12:13:51	1.11
@@ -55,7 +55,10 @@
 		goto error;
 	}
 	/* Set Close-on-exec */
-	fcntl(listen_fd, F_SETFD, 1);
+	if (fcntl(listen_fd, F_SETFD, 1)) {
+		DEBUGLOG("Setting CLOEXEC on client fd faile: %s\n", strerror(errno));
+		goto error;
+	}
 
 	memset(&addr, 0, sizeof(addr));
 	memcpy(addr.sun_path, SINGLENODE_CLVMD_SOCKNAME,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]