[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/3] Refactor vg allocation code



On Wed, Feb 23, 2011 at 02:52:15PM +0100, Zdenek Kabelac wrote:
> Usure about naming strategy - we use  i.e. alloc_lv,
> but most the new function have now operation prefix.
 
alloc_vg for now...because it's paired with free_vg and vg_free is already used
for something else:)

> Also the location after Dave's refactoring patches is unclear.
 
vg.c  - move free_vg there too.

> +	if (!(vgmem = dm_pool_create("lvm2 vg_handle", VG_MEMPOOL_CHUNK)) ||

The code is now shared - "alloc_vg" will have to do, or if that makes
the log too hard to understand, pass the existing strings into the function.

Ack.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]