[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 22/23] Remove dead assignment in dm_event_get_registered_device



On Tue, Dec 21, 2010 at 04:41:54PM +0100, Zdenek Kabelac wrote:
> ret assigned from _do_event was actually not used and replaced with next
> assignment without any read of returned value.
 
But does the actual error already get logged somewhere?
(I don't see where.)
Some _do_event() failures are reported, others aren't.  I don't see
why there's a distinction.

A DM_EVENT_CMD_REGISTER_FOR_EVENT failure is logged.
A DM_EVENT_CMD_GET_TIMEOUT failure is not.

Surely these failures should never occur on a properly-running system, so why
not log them all in a similar way?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]