[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2/test t-lvconvert-repair-policy.sh



Dne 19.1.2011 20:22, jbrassow sourceware org napsal(a):
> CVSROOT:	/cvs/lvm2
> Module name:	LVM2
> Changes by:	jbrassow sourceware org	2011-01-19 19:22:07
> 
> Modified files:
> 	test           : t-lvconvert-repair-policy.sh 
> 
> Log message:
> 	Add test to make sure that a log device is retained when a
> 	mirror image fails and the policies are set to:
> 	mirror_image_fault_policy = "replace"
> 	mirror_log_fault_policy = "remove"
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-lvconvert-repair-policy.sh.diff?cvsroot=lvm2&r1=1.7&r2=1.8
> 
> --- LVM2/test/t-lvconvert-repair-policy.sh	2011/01/11 17:05:09	1.7
> +++ LVM2/test/t-lvconvert-repair-policy.sh	2011/01/19 19:22:07	1.8
> @@ -39,6 +39,14 @@
>  cleanup $dev1
>  
>  # Fail a leg of a mirror.
> +# Expected result: Mirror (leg replaced, should retain log)
> +aux disable_dev $dev1
> +repair 'activation { mirror_image_fault_policy = "replace" mirror_log_fault_policy = "remove" }'
> +check mirror $vg mirror
> +lvs | grep mirror_mlog

This will not work properly on systems which are already running lvm. (i.e.
even second test running in parallel).

Test needs to check explicitly for devices it has created - so always add VGs
or PVs on its command line.

Please check more lib/check.sh functions - I assume you want to use active().


>  check mirror $vg mirror
>  lvs | grep mirror_mlog

Same

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]