[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 04/24] Move add_dev_node to DM_DEVICE_RESUME



On 01/30/2011 01:57 PM +0100, Zdenek Kabelac wrote:
> We need valid 'check_udev' for stacked ops processing.

This change would also remove this ugly part in
_create_and_load_v4 fn (the "create with table"):

  /* FIXME: Just for udev_check in dm_task_run. Can we avoid this? */
  task->event_nr = dmt->event_nr & DM_UDEV_FLAGS_MASK;
  task->cookie_set = dmt->cookie_set;

I had to copy this artificially for the DM_DEVICE_CREATE task
just to set the udev_check correctly in dm_task_run. Though,
unfortunately, it does not work when we have the CREATE, LOAD
and RESUME separated. So this fix is highly welcome!

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]