[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/2] Fix read byte from char[-1] position



On Wed, Mar 02, 2011 at 07:09:07PM +0100, Zdenek Kabelac wrote:
> When the ->params is empty string - access is made on the byte
> before allocated buffer (catched by valgrind) - in case it would
> constains 0x20 - it would even overwrite this buffer.
> So fix by checking len > 0 before doing such access.
> Optimise the code and use len counter instead of multiple strlen calls.
 
Needing more context for this one:
  Under what conditions is the bug triggered?
  What are the implications when it is?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]