[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2/libdm/ioctl libdm-iface.c



On 03/06/2011 02:18 AM, Alasdair G Kergon wrote:
> On Sat, Mar 05, 2011 at 09:17:19PM -0000, mbroz sourceware org wrote:
>> 	This feature is not yet upstream and becuase cryptsetup in next version
>> 	uses this flag, it will cause a lot of noise on old kernels.
>  
> Let's take this as a temporary change then, and once the new code becomes
> reasonably widely used, revert this patch, OK?

IMHO that message should not be there at all. If application relies on
it, then it must fail completely, warning is not enough.
For other uses it is optional.

Anyway, we can revert it even now, I added version check into cryptsetup
to detect kernel DM version and do not use that call if it is old.
And the same change will be needed in RHEL or people will complain...

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]