[lvm-devel] [PATCH 1 of 1] LVM: fix macro call

Jonathan Brassow jbrassow at redhat.com
Wed Mar 16 00:31:35 UTC 2011


Patch name: lvm-fix-macro-call.patch

This 'bug' has been around for more than 5 years... originally put in here:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?r1=1.93&r2=1.94&cvsroot=lvm2&f=h

Thing is, I'm not sure how it was ever suppose to work - it's the wrong type
of argument to the macro.  Perhaps the macro has changed, or perhaps I just don't
get it.

Index: LVM2/tools/lvcreate.c
===================================================================
--- LVM2.orig/tools/lvcreate.c
+++ LVM2/tools/lvcreate.c
@@ -346,7 +346,7 @@ static int _lvcreate_params(struct lvcre
 	lp->mirrors = 1;
 
 	/* Default to 2 mirrored areas if --type mirror */
-	if (seg_is_mirrored(lp))
+	if (segtype_is_mirrored(lp->segtype))
 		lp->mirrors = 2;
 
 	if (arg_count(cmd, mirrors_ARG)) {




More information about the lvm-devel mailing list