[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1 of 1] LVM: fix macro call



On Tue, Mar 15, 2011 at 07:31:35PM -0500, Jon Brassow wrote:
> This 'bug' has been around for more than 5 years... originally put in here:
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?r1=1.93&r2=1.94&cvsroot=lvm2&f=h
> Thing is, I'm not sure how it was ever suppose to work - it's the wrong type
> of argument to the macro.  Perhaps the macro has changed, or perhaps I just don't
> get it.
 
The macro works - it's not a function - as long as the struct has a
member with that name (and it does) it's fine.  But do change it if you
think the other way is easier to read.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]