[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2/libdm/ioctl libdm-iface.c



Dne 20.3.2011 03:00, agk sourceware org napsal(a):
> CVSROOT:	/cvs/lvm2
> Module name:	LVM2
> Changes by:	agk sourceware org	2011-03-20 02:00:52
> 
> Modified files:
> 	libdm/ioctl    : libdm-iface.c 
> 
> Log message:
> 	Fix last checkin - added error message text wrong.
> 
> Patches:

>  
> -	if (!_dm_compat) {
> -		log_error("Support for older device-mapped version is disabled.");
> -		goto bad;
> -	}
> +	if (!_dm_compat)
> +		goto_bad;

My patch was only fixing error reporting logic.

Now it's reports 'stack' trace before the actual report.

AFAIK your own rule is - to always report error first and then report 'stack'
traces upward.

Did I get this rule wrong - are there some exceptions?

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]