[lvm-devel] [PATCH 6/8] Use id_equal instead of strncmp()
Zdenek Kabelac
zkabelac at redhat.com
Tue Mar 22 21:34:15 UTC 2011
It's better for code reading and code consistency.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
lib/metadata/metadata.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 1d711bc..f4d4671 100644
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -3038,8 +3038,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
continue;
}
- if (strncmp((char *)vg->id.uuid,
- (char *)correct_vg->id.uuid, ID_LEN)) {
+ if (!id_equal(&vg->id, &correct_vg->id)) {
inconsistent = 1;
inconsistent_vgid = 1;
}
@@ -3287,7 +3286,7 @@ static struct volume_group *_vg_read_by_vgid(struct cmd_context *cmd,
vginfo->vgname && !is_orphan_vg(vginfo->vgname)) {
if ((vg = _vg_read(cmd, NULL, vgid, 1,
&consistent, precommitted)) &&
- !strncmp((char *)vg->id.uuid, vgid, ID_LEN)) {
+ id_equal(&vg->id, (const struct id *)vgid)) {
if (!consistent)
log_error("Volume group %s metadata is "
"inconsistent", vg->name);
@@ -3318,7 +3317,7 @@ static struct volume_group *_vg_read_by_vgid(struct cmd_context *cmd,
consistent = 0;
if ((vg = _vg_read(cmd, vgname, vgid, 1, &consistent,
precommitted)) &&
- !strncmp((char *)vg->id.uuid, vgid, ID_LEN)) {
+ id_equal(&vg->id, (const struct id *)vgid)) {
if (!consistent) {
log_error("Volume group %s metadata is "
"inconsistent", vgname);
--
1.7.4.1
More information about the lvm-devel
mailing list