[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/6] Pool locking code



Dne 23.3.2011 19:41, Joe Thornber napsal(a):
> On Wed, 2011-03-23 at 16:57 +0100, Zdenek Kabelac wrote:
>> If there would be just 1 vg read for 7200 activate call - obviously
>> I'd not
>> need to play with this dm_pool locking :)
>>
>> So there is 7200 vg reads - which will use this one locked pool with
>> my patch set:
> 
> ok, so I'm playing catch-up;  This locking functionality is debug only.
> In the near term the set/restore api wont be needed at all, at which
> point that interface can be removed.  We should leave the locking side
> for regression tests.


Yes - the locking has rather 'debug' semantic to catch writes to vg mempool.

But I'm not sure what do you mean here by 'set/restore api won't be needed' ?

As currently I need to restore the content of the modified part of mempool to
return always the same memory like it would be created 1st time.
(Unless you mean here, that you would rather change the code which modifies
lv/vg->status - so these flag would not need to be restored - which would be a
nice option - but would certainly require bigger modification of the code.)

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]