[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Add configure option to select default run directory base and prepare for early /run use



On 10/21/2011 12:55 PM, Zdenek Kabelac wrote:
> Dne 21.10.2011 11:50, Peter Rajnoha napsal(a):
>>  AH_TEMPLATE(DEFAULT_RUN_DIR, [Name of default run directory.])
>>  AC_ARG_WITH(default-run-dir,
>> -	    [  --with-default-run-dir=DIR       Default run directory [[/var/run/lvm]] ],
>> +	    [  --with-default-run-dir=DIR       Default run directory [[RDIR/lvm]] ],
>>  	    [ DEFAULT_RUN_DIR="$withval" ],
>> -	    [ DEFAULT_RUN_DIR="/var/run/lvm" ])
>> +	    [ DEFAULT_RUN_DIR="$DEFAULT_RUN_DIR_BASE/lvm" ])
>>  AC_DEFINE_UNQUOTED(DEFAULT_RUN_DIR,["$DEFAULT_RUN_DIR"] )
>>  
> 
> 
> I guess we should stay with just one place to configure /var/run
> 
> So I'd replace DEFAULT_RUN_DIR usage in the code  with  DEFAULT_RUN_DIR/lvm
> and use just this define.

That's an option as well. Depends on whether we're OK with redefining it this
way... but yes, I'd say it can't do any harm.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]