[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Avoid recursive calls from dmeventd to itself



On Thu, Sep 01, 2011 at 03:08:03AM +0200, Peter Rockai wrote:
> -		lvm2_run(_lvm_handle, "_memlock_dec");
> +		lvm2_run(_lvm_handle, "_dmeventd_leave");

I'm not keen on overloading it like that.

If it's being used with cmdlib and lvm2_run, use of existing cmdline parameters
ought to be sufficient to achieve this.

It might be a little more code, but I'd rather see it a property of the handle
never to perform dmeventd monitoring calls.  We never fixed handle init to 
take multiple settings, so maybe call
  void lvm2_disable_dmeventd_monitoring(void *handle)
after handle initialisation to set DMEVENTD_MONITOR_DISABLED and have that take
precedence over any later attempt to enable monitoring.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]