[lvm-devel] [RFC PATCH 0/3] optimize detection of MD devices
Alasdair G Kergon
agk at redhat.com
Mon Jul 16 22:17:58 UTC 2012
On Mon, Jul 16, 2012 at 11:18:36PM +0200, dongsu.park at profitbricks.com wrote:
> This patchset optimizes the detection mechanism of MD devices, as well
Optimising the detection, good.
> as introduces a possibility to turn off detections of the legacy
> metadata versions.
Maybe, but I'd discourage people from turning it off more strongly, as it's a
small price to pay for peace of mind.
So, after review and a bit of tweaking, yes, I'm in favour.
However, the whole of this code is itself 'legacy' in that this detection is
moving into blkid under udev's control, so you should check if that code is
sufficiently efficient too.
Alasdair
More information about the lvm-devel
mailing list