[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] liblvm2app stripe_size reported wrong



On Wed, Jul 04, 2012 at 02:01:36PM -0700, ben wrote:
> Sector size is changing to a mix of 512 and 4k which will add to the confusion 
> if it reports sectors.

Like in the kernel, we have a convention that sectors are always treated as 512
bytes.
 
commit 0bc382eae4cf77bdec9e5a2fdb11c72db64438bb
Author: Petr Rockai <prockai redhat com>
Date:   Thu Nov 25 14:39:02 2010 +0000

    All 'size' values of lvm2app properties should be in bytes.
    Fix 'seg_size' to return bytes.
    
    Signed-off-by: Dave Wysochanski <wysochanski pobox com>
    Reviewed-by: Petr Rockai <prockai redhat com>


But if the assertion that all size values should be in bytes is true, why
did that patch only change one field and not these others?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]