[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Remove fifos on dmeventd shutdown



On Wed, Mar 14, 2012 at 03:23:07PM +0100, Peter Rajnoha wrote:
>  	/* Set the rest of the signals to cause '_exit_now' to be set */
> +	signal(SIGTERM, &_exit_handler);
>  	signal(SIGINT, &_exit_handler);
>  	signal(SIGHUP, &_exit_handler);
>  	signal(SIGQUIT, &_exit_handler);

I'd prefer it if we used sigaction() directly like we do elsewhere in lvm
so we can specify precisely the behaviour we intend.

signal() has a bad history and, as the man page states, should be avoided.
 
Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]