[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH][just nitpicking :)] Make vgscan behaviour consistent with pvscan



Hi,

Peter Rajnoha <prajnoha redhat com> writes:
> Just this minor thing... Are you OK with this?
>
> If using "--cache" opt, we directly scan and update lvmetad if running.
> If not using "--cache" opt, we get the info from lvmetad if running.

yes, I think this is good for UI consistency. One thing to watch out for
though is on-disk metadata inconsistencies. Before the patch, any
"vgscan" would notice those, but afterwards, only "vgscan --cache" can
be used to detect bad on-disk metadata.

We could also want to extend pvscan --cache to report (and maybe fix?)
any metadata inconsistencies it may find.

[snip; patch looks OK]

Petr

-- 
id' Ash = Ash; id' Dust = Dust; id' _ = undefined


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]