[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH]: Allow limited metadata changes when PVs are missing



Hi,

Jonathan Brassow <jbrassow redhat com> writes:
> The solution is to allow vgchange and lvchange to alter the LVM metadata
> for a limited set of options - --[add|del]tag included.  The set of
> allowable options are ones that do not cause changes to the DM kernel
> target (like --resync would) or could alter the structure of the LV
> (like allocation or conversion).

seems OK to me. Nevertheless, I would like to see a functional test
along with the patch, to make sure the newly allowed options actually
work as expected. Other than the missing test, ACK.

Petr

-- 
id' Ash = Ash; id' Dust = Dust; id' _ = undefined


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]