[lvm-devel] [PATCH 1/2] lvm2app: Add function to retrieve the origin.
Tony Asleson
tasleson at redhat.com
Fri Apr 12 15:44:11 UTC 2013
On 04/12/2013 03:22 AM, Zdenek Kabelac wrote:
> If you need just 'const' pointer - it would be probably better,
> to directly return the name - instead of duplication.
Agreed.
> i.e. lv_origin_dup() -> rewrite to 'const char *lv_get_origin(.)' ->
> and use it for lv_name_dup() in lv_origin_dup() which returns char *.
> as well as for lvm_lv_get_origin().
I ran into at least 2 different implementations of *get_origin. There
is lv_origin_dup() and _origin_disp. Both utilize the same logic with
slightly different output. I haven't looked around it see if there are
others.
To clean this up correctly I would want to write what you are suggesting
and then use it in all the different places.
There is quite a bit of code that could certainly benefit from
decoupling the generation/manipulation of the data from the presentation
of it.
I've added this to a todo list.
Regards,
Tony
More information about the lvm-devel
mailing list