[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH V4] lvm2app: Add thin and thin pool lv creation



On 04/12/2013 10:21 AM, Tony Asleson wrote:
> On 04/12/2013 07:40 AM, Zdenek Kabelac wrote:
>  > We really need here separate type of object to set all properties for
> thin.
>> (Since their amount will grow over the time) so you can't solve with any
>> bit field - this is not extensible.
>>
>> We need to create 'object' with properties, that can be controled in C++
>> like way - so we may extend it in future easily, without breaking API,
>> and leaving
>> 'old' unusable calls in the library.
> 
> I will take a swag at something early next week and post for people to
> review.  We need to get something in soon so that people can utilize the
> new thinp stuff.

Mohan, I'm having difficultly getting your patch to apply at the moment.
 I wanted to use it as the basis of this work.  Would you have time to
update your patch against head?

I was going to create a new opaque type, create a base initialize
function and then add get/set functions for items you have.  This would
then become the parameter to feed into the thinp functions.  I was going
to omit the low water mark for now.

I don't know off hand what all the possible parameters for the thin pool
creation vs. the thin lv creation, but from the patch it looks like thus
far there are more parameters when creating the thin pool?  Do we need
opaque parameters for the thin pool creation and the thin logical volume
creation?

You are more than welcome to take a pass at this too if you have the
bandwidth :-)

Thanks,
Tony


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]