[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 2/3] lvm2app: Implementation of lv resize (v1)



On 01/08/2013 04:44 AM, Zdenek Kabelac wrote:
> I'd prefer here to see separate patches which are
> just moving code and then new patches for changes
> of moved code.

New patch set submitted.  Some changes needed to occur to allow the code
to be moved.  This is broken down step by step.  Hopefully this will
make it easier to see what is going on.

> After moving code - try to add  '_' prefixes to internal 'static'
> functions.

OK

> we have macro shortcut - return_0;

Using it now.

> goto_out

Using this too...

> {} around single commands unneeded

OK

Thanks,
Tony


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]